Adds a new snow compaction & routing scheme in ELM #6413
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
with improved snow physics in a 5 layer scheme
…hicker/elm/use_extrasnowlayers-5lyrs/1_ERA5" This reverts commit 3d35017ffb2388120ed0c34b7061e0abccc8c88b, reversing changes made to b29ce48444e433697343bd60caab6262096aa2b4. merged wrong branch
…a5' into cwhicker/elm/use_extrasnowlayers-5lyrs/1_ERA5_mastermerge
…a5' into cwhicker/elm/use_extrasnowlayers-5lyrs/1_ERA5_mastermerge
…a5' into cwhicker/elm/use_extrasnowlayers-5lyrs/1_ERA5_mastermerge
…a5' into cwhicker/elm/use_extrasnowlayers-5lyrs/1_ERA5_mastermerge_fcf5bad
…a5' into cwhicker/elm/use_extrasnowlayers-5lyrs/1_ERA5_mastermerge_fcf5bad add GB's change "updates test to not use testmods"
…rn_percolation_and_compaction
|
Can you fix the PR title? |
chloewhicker
changed the title
chloewhicker
changed the title
bishtgautam
reviewed
Jun 13, 2024
| @@ -249,7 +249,8 @@ subroutine elm_varcon_init() | |||
| allocate( dzsoifl(1:nlevsoifl )) | |||
|
|
|||
| if (use_extrasnowlayers) then | |||
| h2osno_max = 30000._r8 | |||
| !h2osno_max = 1000._r8 | |||
There was a problem hiding this comment.
can you please delete this commented out line?
There was a problem hiding this comment.
Done. Thanks for catching that.
bishtgautam
added a commit
that referenced
this pull request
Jun 24, 2024
…next (PR #6413) Modifies the ELM snowcapping routing scheme along with the snow and firn compaction schemes to include changes made by [Schneider et al., (2022)](https://agupubs.onlinelibrary.wiley.com/doi/10.1029/2021MS002542) but retain the original 5-layer snowpack, these modifications can be turned on by setting use_firn_percolation_and_compaction = .true. in user_nl_elm [BFB] [NML]
bishtgautam
approved these changes
Jun 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modifies the ELM snowcapping routing scheme along with the snow and firn compaction
schemes to include changes made by Schneider et al., (2022)
but retain the original 5-layer snowpack, these modifications can be turned on by
setting use_firn_percolation_and_compaction = .true. in user_nl_elm
[BFB]
[NML]
design doc here